Merge pull request #111 from microsoft/copilot/fix-aliases-malformed

Fix malformed shell function aliases in artifacts-helper

Author: markphip

src/artifacts-helper/devcontainer-feature.json

@@ -1,7 +1,7 @@
 {
     "name": "Azure Artifacts Credential Helper",
     "id": "artifacts-helper",
-    "version": "3.0.7",
+    "version": "3.0.8",
     "description": "Configures Codespace to authenticate with Azure Artifact feeds",
     "options": {
         "nugetURIPrefixes": {

src/artifacts-helper/install.sh

@@ -131,14 +131,19 @@ for ALIAS in "${ALIASES_ARR[@]}"; do
     ALIASES_BLOCK+="$ALIAS() { \"${SHIM_DIRECTORY}/$ALIAS\" \"\$@\"; }"$'\n'
 done
 
+_TEMP_BLOCK=$(mktemp)
+printf '%s' "$ALIASES_BLOCK" > "$_TEMP_BLOCK"
+
 for TARGET_FILE in "${TARGET_FILES_ARR[@]}"; do
     if [ "${INSTALL_WITH_SUDO}" = "true" ]; then
-        sudo -u ${_REMOTE_USER} bash -c "printf '%s' \"$ALIASES_BLOCK\" >> $TARGET_FILE"
+        sudo -u "${_REMOTE_USER}" bash -c "cat '$_TEMP_BLOCK' >> $TARGET_FILE"
     else
-        printf '%s' "$ALIASES_BLOCK" >> "$TARGET_FILE" || true
+        cat "$_TEMP_BLOCK" >> "$TARGET_FILE" || true
     fi
 done
 
+rm -f "$_TEMP_BLOCK"
+
 if [ "${INSTALL_WITH_SUDO}" = "true" ]; then
     sudo -u ${_REMOTE_USER} bash -c "/tmp/install-provider.sh ${USENET6}"
 fi

test/artifacts-helper/test_shim_integration.sh

@@ -29,6 +29,10 @@ check "npm shell function written to bash.bashrc" grep -q "npm()" /etc/bash.bash
 check "dotnet shell function written to bash.bashrc" grep -q "dotnet()" /etc/bash.bashrc
 check "npm shell function on its own line in bash.bashrc" grep -q "^npm()" /etc/bash.bashrc
 
+# Verify aliases include proper quoting and argument passing ($@)
+check "dotnet alias has quoted path and passes args" grep -q 'dotnet() { ".*/dotnet" "\$@"; }' /etc/bash.bashrc
+check "npm alias has quoted path and passes args" grep -q 'npm() { ".*/npm" "\$@"; }' /etc/bash.bashrc
+
 # Verify newlines between shim definitions (each function should be on its own line)
 check "each shim function is on its own line" bash -c '
     # Count function definitions at line starts - with proper newlines each will start at column 0