refactor(web): remove success toasts for list changes and define toast types (#43832)

Author: lyzno1

web/app/account/(commonLayout)/account-page/AvatarWithEdit.tsx

@@ -37,23 +37,21 @@ const AvatarWithEdit = (props: AvatarProps) => {
       try {
         await updateProfile({ body: { avatar: uploadedFileId } })
         setIsShowAvatarPicker(false)
-        toast.success(t(($) => $['actionMsg.modifiedSuccessfully'], { ns: 'common' }))
       } catch (e) {
         toast.error((e as Error).message)
       }
     },
-    [t, updateProfile],
+    [updateProfile],
   )
 
   const handleDeleteAvatar = useCallback(async () => {
     try {
       await updateProfile({ body: { avatar: '' } })
-      toast.success(t(($) => $['actionMsg.modifiedSuccessfully'], { ns: 'common' }))
       setIsShowDeleteConfirm(false)
     } catch (e) {
       toast.error((e as Error).message)
     }
-  }, [t, updateProfile])
+  }, [updateProfile])
 
   const handleDeleteAvatarClick = useCallback(() => {
     setIsShowAvatarPicker(false)

web/app/components/app/create-app-modal/__tests__/index.spec.tsx

@@ -97,7 +97,7 @@ const mockUseRouter = vi.mocked(useRouter)
 const mockPush = vi.fn()
 const mockTrackCreateApp = vi.mocked(trackCreateApp)
 const mockGetRedirection = vi.mocked(getRedirection)
-const { mockToastSuccess, mockToastError } = toastMocks
+const { mockToastError } = toastMocks
 
 let appQuota = { size: 0, limit: 1 }
 
@@ -136,7 +136,7 @@ describe('CreateAppModal', () => {
     mockConsoleState.workspacePermissionKeys = ['app.create_and_management']
   })
 
-  it('creates an app, notifies success, and fires callbacks', async () => {
+  it('creates an app and fires callbacks', async () => {
     const mockApp = createAppDetailFixture({
       mode: AppModeEnum.ADVANCED_CHAT,
       maintainer: 'user-1',
@@ -163,7 +163,6 @@ describe('CreateAppModal', () => {
       source: 'studio_blank',
       appMode: AppModeEnum.ADVANCED_CHAT,
     })
-    expect(mockToastSuccess).toHaveBeenCalledWith('app.newApp.appCreated')
     expect(onClose).toHaveBeenCalledTimes(1)
     await waitFor(() =>
       expect(mockGetRedirection).toHaveBeenCalledWith(mockApp, mockPush, {
@@ -419,7 +418,7 @@ describe('CreateAppModal', () => {
 
     resolveCreate?.(createAppDetailFixture({ id: 'slow-app', mode: AppModeEnum.ADVANCED_CHAT }))
     await waitFor(() => {
-      expect(mockToastSuccess).toHaveBeenCalledWith('app.newApp.appCreated')
+      expect(mockGetRedirection).toHaveBeenCalledTimes(1)
     })
   })
 })

web/app/components/app/create-app-modal/index.tsx

@@ -133,7 +133,6 @@ function CreateApp({ onClose, onCreateFromTemplate, defaultAppMode }: CreateAppP
         // Analytics should not turn a successful app creation into a failed flow.
       }
 
-      toast.success(t(($) => $['newApp.appCreated'], { ns: 'app' }))
       onClose()
       getRedirection(app, push, {
         currentUserId,

web/app/components/app/switch-app-modal/__tests__/index.spec.tsx

@@ -247,7 +247,7 @@ describe('SwitchAppModal', () => {
     it('should switch app and navigate with push when keeping original', async () => {
       const user = userEvent.setup()
       // Arrange
-      const { appDetail, notify, onClose } = renderComponent()
+      const { appDetail, onClose } = renderComponent()
       mockConvertToWorkflow.mockResolvedValueOnce({
         new_app_id: 'new-app-001',
         permission_keys: ['app.acl.view_layout'],
@@ -268,7 +268,6 @@ describe('SwitchAppModal', () => {
           },
         })
         expect(onClose).toHaveBeenCalledTimes(1)
-        expect(notify).toHaveBeenCalledWith({ type: 'success', message: 'app.newApp.appCreated' })
         expect(mockPush).toHaveBeenCalledWith('/app/new-app-001/workflow')
         expect(mockReplace).not.toHaveBeenCalled()
       })

web/app/components/app/switch-app-modal/index.tsx

@@ -98,7 +98,6 @@ const SwitchAppModal = ({ show, sourceApp, onClose }: SwitchAppModalProps) => {
         },
       })
       onClose()
-      toast.success(t(($) => $['newApp.appCreated'], { ns: 'app' }))
       if (removeOriginal)
         await deleteOriginalApp({
           params: { app_id: sourceApp.id },

web/app/components/apps/app-card/interactions.tsx

@@ -323,7 +323,6 @@ export function AppCardInteractions({
         { params: { app_id: app.id } },
         {
           onSuccess: () => {
-            toast.success(t(($) => $.appDeleted, { ns: 'app' }))
             setActiveDialog(null)
             setConfirmDeleteInput('')
           },
@@ -453,7 +452,6 @@ export function AppCardInteractions({
             }
 
             setActiveDialog(null)
-            toast.success(t(($) => $['newApp.appCreated'], { ns: 'app' }))
             getRedirection(newApp, push, {
               currentUserId,
               resourceMaintainer: newApp.maintainer ?? undefined,

web/app/components/datasets/documents/detail/completed/hooks/__tests__/use-child-segment-data.spec.ts

@@ -327,10 +327,6 @@ describe('useChildSegmentData', () => {
       })
 
       expect(mockUpdateChildSegment).toHaveBeenCalled()
-      expect(mockNotify).toHaveBeenCalledWith({
-        type: 'success',
-        message: 'common.actionMsg.modifiedSuccessfully',
-      })
       expect(onCloseChildSegmentDetail).toHaveBeenCalled()
       expect(updateSegmentInCache).toHaveBeenCalled()
       expect(refreshChunkListDataWithDetailChanged).toHaveBeenCalled()

web/app/components/datasets/documents/detail/completed/hooks/use-child-segment-data.ts

@@ -174,7 +174,6 @@ export const useChildSegmentData = (
         { datasetId, documentId, segmentId: segmentIdParam, childChunkId, body: params },
         {
           onSuccess: (res) => {
-            toast.success(t(($) => $['actionMsg.modifiedSuccessfully'], { ns: 'common' }))
             onCloseChildSegmentDetail()
             if (parentMode === 'paragraph') {
               // Update parent segment's child_chunks in cache

web/app/components/datasets/external-api/external-api-modal/__tests__/index.spec.tsx

@@ -190,10 +190,6 @@ describe('AddExternalAPIModal', () => {
             settings: { endpoint: 'https://test.com', api_key: 'key12345' },
           },
         })
-        expect(mockNotify).toHaveBeenCalledWith({
-          type: 'success',
-          message: 'External API saved successfully',
-        })
         expect(onSave).toHaveBeenCalledWith(mockResponse)
         expect(onCancel).toHaveBeenCalled()
       })
@@ -335,10 +331,6 @@ describe('AddExternalAPIModal', () => {
 
       const confirmButton = screen.getByRole('button', { name: /confirm/i })
       fireEvent.click(confirmButton)
-
-      await waitFor(() => {
-        expect(mockNotify).toHaveBeenCalledWith(expect.objectContaining({ type: 'success' }))
-      })
     })
 
     it('should close confirm dialog when cancel is clicked', async () => {

web/app/components/datasets/external-api/external-api-modal/index.tsx

@@ -106,13 +106,9 @@ const AddExternalAPIModal: FC<AddExternalAPIModalProps> = ({
           ...formData,
           settings: { ...formData.settings, api_key: apiKeyToSend },
         })
-        toast.success('External API updated successfully')
       } else {
         const res = await createExternalAPI({ body: formData })
-        if (res && res.id) {
-          toast.success('External API saved successfully')
-          onSave(res)
-        }
+        if (res && res.id) onSave(res)
       }
       onCancel()
     } catch (error) {