You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d16cb10
Browse filesBrowse the repository at this point in the historyBrowse files
test(conclude): expand conformance matrix for gh-aw-threat-detection#694 (#738)
* test(conclude): expand conformance matrix for gh-aw-threat-detection#694
Add test cases covering the full {result state} x {warn/strict} x
{execution outcome} matrix for the `conclude` subcommand: success is
unaffected by warn mode/executionFailed, threat_detected always warns
in warn mode (mustFail excludes it), malformed/missing/unreadable
result files are exercised across all warn-mode/executionFailed
combinations to confirm mustFail scoping.
conclude.go itself already implements the fixes called for in the
issue (writes reason/conclusion on every fail path including strict
missing-file, exports GH_AW_DETECTION_* consistently, and documents
the mustFail divergence in specs/threat-detection-spec.md TD-20b/21a).
The remaining divergence is entirely in gh-aw's
actions/setup/sh/conclude_threat_detection.sh, which lives in the
github/gh-aw repo and is out of scope for this repo.
Co-authored-by: David Slater <12449447+davidslater@users.noreply.github.com>
* test(conclude): fill remaining matrix gaps from review feedback
Add strict-mode + executionFailed=true cases for malformed and
unreadable result files, and assert success/GH_AW_DETECTION_CONCLUSION
on the unreadable-file matrix (previously only reason/conclusion were
checked), per copilot-pull-request-reviewer feedback on #738.
Co-authored-by: David Slater <12449447+davidslater@users.noreply.github.com>
---------
Co-authored-by: GitHub Ace <githubnext@users.noreply.github.com>
Co-authored-by: David Slater <12449447+davidslater@users.noreply.github.com>
0 commit comments