Skip to content

docs: fix dead links to the Sentinel example and RocketMQ docs - #4426

Open
farisbasha wants to merge 1 commit into
alibaba:2025.1.xfrom
farisbasha:docs-fix-dead-links
Open

farisbasha wants to merge 1 commit into
alibaba:2025.1.xfrom
farisbasha:docs-fix-dead-links

Conversation

@farisbasha

Copy link
Copy Markdown

Describe what this PR does / why we need it

Fixes several documentation links that return 404:

File Old link New link
README.md, README-zh.md (Examples list) tree/2025.1.x/.../sentinel-example/sentinel-core-example/readme(-zh).md (the file does not exist) blob/2025.1.x/.../sentinel-example/README(-zh).md, the Sentinel example readme
sentinel-example/README.md, README-zh.md github.com/alibaba/Sentinel/tree/2021.x/sentinel-demo/sentinel-demo-annotation-spring-aop (Sentinel has no 2021.x branch) same path on Sentinel's default branch 1.8
rocketmq-example/readme.md, readme-zh.md rocketmq.apache.org/docs/filter-by-sql92-example/ rocketmq.apache.org/docs/featureBehavior/07messagefilter/ (Message Filtering, covers tag and SQL92 filters)
RocketMQCommonProperties Javadoc of group rocketmq.apache.org/docs/core-concept/ rocketmq.apache.org/docs/domainModel/01main/ (domain model overview: producer and consumer groups)

Does this pull request fix one issue?

NONE

Describe how you did it

Ran a link check over the Markdown and Java sources, then looked up the current location of each page (the RocketMQ pages through the site's sitemap, the GitHub paths through the GitHub API).

Describe how to verify it

Open the new links: each one resolves (HTTP 200) and shows the same topic as the old one. Docs and one Javadoc comment only, no code change.

Special notes for reviews

Prepared with AI assistance (Claude Code).

- README.md / README-zh.md: the Sentinel example link points to
  sentinel-core-example/readme(-zh).md, which does not exist; the
  example readme lives in sentinel-example/README(-zh).md.
- sentinel-example README: alibaba/Sentinel has no 2021.x branch; use
  its default branch 1.8.
- rocketmq-example readme and RocketMQCommonProperties Javadoc: the old
  rocketmq.apache.org/docs/filter-by-sql92-example/ and
  /docs/core-concept/ pages are gone; link the current message
  filtering and domain model pages.
@CLAassistant

CLAassistant commented Nov 17, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants