Repository navigation
docs: fix dead links to the Sentinel example and RocketMQ docs - #4426
Open
farisbasha wants to merge 1 commit into
Open
farisbasha wants to merge 1 commit into
farisbasha wants to merge 1 commit into
Conversation
- README.md / README-zh.md: the Sentinel example link points to sentinel-core-example/readme(-zh).md, which does not exist; the example readme lives in sentinel-example/README(-zh).md. - sentinel-example README: alibaba/Sentinel has no 2021.x branch; use its default branch 1.8. - rocketmq-example readme and RocketMQCommonProperties Javadoc: the old rocketmq.apache.org/docs/filter-by-sql92-example/ and /docs/core-concept/ pages are gone; link the current message filtering and domain model pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Fixes several documentation links that return 404:
README.md,README-zh.md(Examples list)tree/2025.1.x/.../sentinel-example/sentinel-core-example/readme(-zh).md(the file does not exist)blob/2025.1.x/.../sentinel-example/README(-zh).md, the Sentinel example readmesentinel-example/README.md,README-zh.mdgithub.com/alibaba/Sentinel/tree/2021.x/sentinel-demo/sentinel-demo-annotation-spring-aop(Sentinel has no2021.xbranch)1.8rocketmq-example/readme.md,readme-zh.mdrocketmq.apache.org/docs/filter-by-sql92-example/rocketmq.apache.org/docs/featureBehavior/07messagefilter/(Message Filtering, covers tag and SQL92 filters)RocketMQCommonPropertiesJavadoc ofgrouprocketmq.apache.org/docs/core-concept/rocketmq.apache.org/docs/domainModel/01main/(domain model overview: producer and consumer groups)Does this pull request fix one issue?
NONE
Describe how you did it
Ran a link check over the Markdown and Java sources, then looked up the current location of each page (the RocketMQ pages through the site's sitemap, the GitHub paths through the GitHub API).
Describe how to verify it
Open the new links: each one resolves (HTTP 200) and shows the same topic as the old one. Docs and one Javadoc comment only, no code change.
Special notes for reviews
Prepared with AI assistance (Claude Code).