Repository navigation
fix: Preserve data when splitting Upstash chunks - #6916
Open
Arthur031221 wants to merge 1 commit into
Open
Arthur031221 wants to merge 1 commit into
Arthur031221 wants to merge 1 commit into
Conversation
Author
|
Anything else you want changed? I can rebase if needed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Type
Description of Change
Upstash sync can lose spaces from backups because the splitter drops the space at each boundary and the reader joins chunks without a separator. Long text without spaces can also exceed the chunk limit. This change splits by byte length, keeping UTF-8 characters and byte-order-mark characters intact so uploads and downloads preserve the serialized backup.
Additional Information
Added regression coverage for exact Upstash round trips and UTF-8 chunk boundaries. Tested with
yarn test:ci --runInBand test/format-chunks.test.ts test/upstash.test.ts.Assisted by Claude/Codex.